From e8230b28a9d4dd887adc2d080b81482b2d47b185 Mon Sep 17 00:00:00 2001
From: Kipras Melnikovas <kipras@kipras.org>
Date: Fri, 14 Feb 2020 16:50:11 +0200
Subject: [PATCH] Use different IDs for 1) getting the directory of yarn cache
2) the cache itself (#178)
* Use different IDs for 1) getting the directory of yarn cache 2) the cache itself
Using the current example + https://github.com/actions/cache#skipping-steps-based-on-cache-hit,
I came to a wrong conclusion that I could skip a step
if the `cache-hit` was `true` -
the ID I used was from the wrong step -
the `get yarn cache directory` step,
instead of the `get yarn cache itself` step.
I've updated the example in hopes that it'll be clearer for others aswell!
Signed-off-by: Kipras Melnikovas <kipras@kipras.org>
* Explain which ID to use for `cache-hit` in yarn's example
Signed-off-by: Kipras Melnikovas <kipras@kipras.org>
---
examples.md | 12 +++++++-----
1 file changed, 7 insertions(+), 5 deletions(-)
diff --git a/examples.md b/examples.md
index cb092dd..1b0d0c0 100644
--- a/examples.md
+++ b/examples.md
@@ -140,7 +140,7 @@ For npm, cache files are stored in `~/.npm` on Posix, or `%AppData%/npm-cache` o
### Using multiple systems and `npm config`
-```yaml
+```yaml
- name: Get npm cache directory
id: npm-cache
run: |
@@ -157,21 +157,23 @@ For npm, cache files are stored in `~/.npm` on Posix, or `%AppData%/npm-cache` o
The yarn cache directory will depend on your operating system and version of `yarn`. See https://yarnpkg.com/lang/en/docs/cli/cache/ for more info.
```yaml
-- name: Get yarn cache
- id: yarn-cache
+- name: Get yarn cache directory path
+ id: yarn-cache-dir-path
run: echo "::set-output name=dir::$(yarn cache dir)"
- uses: actions/cache@v1
+ id: yarn-cache # use this to check for `cache-hit` (`steps.yarn-cache.outputs.cache-hit != 'true'`)
with:
- path: ${{ steps.yarn-cache.outputs.dir }}
+ path: ${{ steps.yarn-cache-dir-path.outputs.dir }}
key: ${{ runner.os }}-yarn-${{ hashFiles('**/yarn.lock') }}
restore-keys: |
${{ runner.os }}-yarn-
```
+
## PHP - Composer
-```yaml
+```yaml
- name: Get Composer Cache Directory
id: composer-cache
run: |